Fix #457

[paf31]

I think this fixes #457 but I want to make sure it definitely hasn't broken anything before merging.

Also, I'm not sure this is a general fix for the issue - it might just magically work in this case.

[coveralls]

Coverage increased (+0.21%) when pulling 77fe482 on 457 into 3634a8d on master.

[garyb]

This seems sensible to me, but I only have a general understanding of what's going on here.

[garyb]

Hmm, it does break some stuff though, from purescript-node-fs:

>> Compiling Node.FS.Sync
>> Error at src/Node/FS/Sync.purs line 162, column 38:
>> Error in declaration realpath'
>> Cannot unify cache443 with u477.

[paf31]

Ah, I spotted that, then cleaned Bower and couldn't reproduce it. Is there any chance you could turn verbose errors on and paste the result?

[garyb]

Yeah, I had that happen too, in test-everything. A bit worrying perhaps. It fails every time in purescript-node-fs though.

Here's the verbose output:

>> Compiling Node.FS.Sync
>> Error at src/Node/FS/Sync.purs line 162, column 38: 
>> Error in declaration realpath'
>> Error in expression \path -> \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)):
>> Error checking type of term \path -> \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)) against type forall eff cache. Node.Path.FilePath<> -> {  | cache } -> Control.Monad.Eff.Eff (err :: Control.Monad.Eff.Exception.Exception, fs :: Node.FS.FS | eff) Node.Path.FilePath<>
>> Error in expression \path -> \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)):
>> Error checking type of term \path -> \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)) against type forall eff. Node.Path.FilePath<> -> {  | cache443 } -> Control.Monad.Eff.Eff (err :: Control.Monad.Eff.Exception.Exception, fs :: Node.FS.FS | eff) Node.Path.FilePath<>
>> Error in expression \path -> \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)):
>> Error checking type of term \path -> \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)) against type Node.Path.FilePath<> -> {  | cache443 } -> Control.Monad.Eff.Eff (err :: Control.Monad.Eff.Exception.Exception, fs :: Node.FS.FS | eff445) Node.Path.FilePath<>
>> Error in expression \path -> \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)):
>> Error checking type of term \path -> \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)) against type Prim.String -> {  | cache443 } -> Control.Monad.Eff.Eff (err :: Control.Monad.Eff.Exception.Exception, fs :: Node.FS.FS | eff445) Prim.String
>> Error in expression \path -> \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)):
>> Error checking type of term \path -> \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)) against type Prim.String -> {  | cache443 } -> Control.Monad.Eff.Eff (err :: Control.Monad.Eff.Exception.Exception, fs :: Node.FS.FS | eff445) Prim.String
>> Error in expression \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)):
>> Error checking type of term \cache -> Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)) against type {  | cache443 } -> Control.Monad.Eff.Eff (err :: Control.Monad.Eff.Exception.Exception, fs :: Node.FS.FS | eff445) Prim.String
>> Error in expression Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)):
>> Error checking type of term Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)) against type Control.Monad.Eff.Eff (err :: Control.Monad.Eff.Exception.Exception, fs :: Node.FS.FS | eff445) Prim.String
>> Error in expression Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)):
>> Error checking type of term Prelude.($)(Node.FS.Sync.mkEff)(\_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)) against type Control.Monad.Eff.Eff (err :: Control.Monad.Eff.Exception.Exception, fs :: Node.FS.FS | eff445) Prim.String
>> Error in expression Prelude.($)(Node.FS.Sync.mkEff):
>> Error applying function of type u449 -> u448 to argument \_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache)
>> Error in expression \_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache):
>> Error checking type of term \_ -> Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache) against type Prelude.Unit -> u452
>> Error in expression Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache):
>> Error checking type of term Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache) against type u452
>> Error in expression Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path)(cache):
>> Error inferring type of value
>> Error in expression Data.Function.runFn2(Node.FS.Sync.fs.realpathSync)(path):
>> Error applying function of type {  | u477 } -> Node.Path.FilePath<> to argument cache
>> Error in expression cache:
>> Error checking type of term cache against type {  | u477 }
>> Error in expression cache:
>> Error checking that type {  | cache443 } subsumes type {  | u477 }
>> Cannot unify cache443 with u477.

[paf31]

@garyb Actually, I get that error with the compiler from master as well. Do you?

[garyb]

I just double checked, and nope, only with this branch. Are you sure you cabal installed after switching back to master? ;)

[paf31]

D'oh. It's because I installed psc to /usr/local to test the Mac binary build script. Thanks :)