Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context menu #71

Closed
Deep-Codes opened this issue Apr 16, 2021 · 3 comments
Closed

context menu #71

Deep-Codes opened this issue Apr 16, 2021 · 3 comments
Assignees

Comments

@Deep-Codes
Copy link
Contributor

I have a bare model of the context menu created.

I didn't use the API for Menubar to implement this, found it too complex 😅.

github

let me know if you want this feature.

@PuruVJ
Copy link
Owner

PuruVJ commented Apr 16, 2021

Looks great. Can you push this code to your own fork's branch so I can take a look?

@Deep-Codes
Copy link
Contributor Author

Looks great. Can you push this code to your own fork's branch so I can take a look?

Yeah Context Menu

This is the most bare model implementation haven't used jotai yet and code is janky
Also why doesn't the hover work in the menu 👀

@PuruVJ
Copy link
Owner

PuruVJ commented Apr 17, 2021

The code seems good to me. I kinda don't like the hard coded menu items, but who am I kidding really, no point in having object-based/dynamic context menu until we have some apps 😉. And we can always refactor it.

About the hoverable thing, it probably needs a sprinkle of z-index: 9999999 or something. Try that, and even if it doesn't work, no issues, I'll fix it by looking at the DOM 3D model.

Overall looks good to me. Please do send a PR. And a request: Before you do that, please run prettier on the files you changed/created 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants