Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Replace gometalinter with golangci-lint #89

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Conversation

mthssdrbrg
Copy link
Contributor

gometalinter is deprecated and will be archived in April (alecthomas/gometalinter#590), so we should switch to golangci-lint.

I've enabled the same linters as we had with gometalinter, and had to fix some files that aren't "goimports-ed (goimports)".

Mathias Söderberg added 2 commits March 1, 2019 12:25
gometalinter is being deprecated in April.
@mthssdrbrg mthssdrbrg requested a review from a team March 1, 2019 12:35
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoelSpeed JoelSpeed merged commit 2314266 into master Mar 4, 2019
@JoelSpeed JoelSpeed deleted the replace-gometalinter branch March 4, 2019 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants