Segfault on OS X

[sarahhodne]

Hey,

Seems like libPusher segfaults on Snow Leopard. The full crash report can be found here: travis-ci/travis-watcher-macosx#3.

Seems like this could be caused by an instance of SRWebSocket not being retained. Looking at the code, it seems like the SRWebSocket instance is just being assigned to an instance variable, which to the best of my knowledge does not retain the instance. I'm not too familiar with Objective-C, though. Is there a reason this isn't assigned with a @property setter? I'd love to submit a pull request if it should be changed, but if it's actually supposed to be this way, then I won't.

[lukeredpath]

Hmm, on first glance I'm not sure what is causing this either.

The code is using ARC and the socket is being assigned to a strong instance variable.

I unfortunately do not have a Snow Leopard machine to test this on.

One theory is that when [socket close] is called in dealloc, it tries to notify its delegate (the PTPusherConnection instance) which has already been deallocced by that point. Maybe I should set the delegate to nil first.

[lukeredpath]

Hmm, given its crashing in didConnect, my theory is unlikely.

[hamchapman]

Closing as stale and seems like it was related to an old version os OS X.