Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write serverSyncStore jobs into the Library folder #120

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

lukabratos
Copy link
Contributor

What?

Persist file into the user's documents folder.


CC @pusher/mobile

@codecov-io
Copy link

codecov-io commented Jul 8, 2019

Codecov Report

Merging #120 into master will decrease coverage by <.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   91.86%   91.86%   -0.01%     
==========================================
  Files          51       51              
  Lines        2607     2617      +10     
==========================================
+ Hits         2395     2404       +9     
- Misses        212      213       +1
Impacted Files Coverage Δ
Tests/SDKTests.swift 100% <100%> (ø) ⬆️
Sources/Persistence/ServerSyncJobStore.swift 89.74% <90.9%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b82d8...e3570b0. Read the comment docs.

Copy link
Contributor

@luismfonseca luismfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@luismfonseca luismfonseca changed the title Write file into the Documents folder Write serverSyncStore jobs into the Library folder Jul 9, 2019
@lukabratos lukabratos merged commit 166dc1f into master Jul 9, 2019
@lukabratos lukabratos deleted the use-file-manager branch July 9, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants