Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift Package Manager support #146

Merged
merged 3 commits into from
Jan 21, 2020
Merged

Swift Package Manager support #146

merged 3 commits into from
Jan 21, 2020

Conversation

grzesiekko
Copy link
Contributor

What?

  • Add Package.swift that defines SPM package.
  • Add instructions on how to integrate using SPM to README.md.
  • Exclude local SPM files from the git repository.

Why?

Swift Package Manager support

CC @pusher/mobile

@codecov-io
Copy link

codecov-io commented Jan 7, 2020 •
edited
Loading

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files          57       57           
  Lines        3326     3326           
=======================================
  Hits         3002     3002           
  Misses        324      324

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158975d...6387390. Read the comment docs.

daniellevass
daniellevass approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@daniellevass daniellevass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@luismfonseca luismfonseca merged commit 837f528 into master Jan 21, 2020
@luismfonseca luismfonseca deleted the feature/spm-support branch January 21, 2020 10:15
@luismfonseca luismfonseca mentioned this pull request Jan 21, 2020
Closed
@grzesiekko grzesiekko added this to the 3.0.2 milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luismfonseca luismfonseca luismfonseca approved these changes

@daniellevass daniellevass daniellevass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grzesiekko @codecov-io @luismfonseca @daniellevass