Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Package Manager integration improvements #162

Merged
merged 6 commits into from
Nov 4, 2020

Conversation

danielrbrowne
Copy link
Contributor

This PR resolves #161

- 'OHHTTPStubsSwift' is only available if integrating via Swift Package Manager
@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #162 into master will decrease coverage by 0.36%.
The diff coverage is 89.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   90.09%   89.72%   -0.37%     
==========================================
  Files          57       57              
  Lines        2898     2921      +23     
==========================================
+ Hits         2611     2621      +10     
- Misses        287      300      +13     
Impacted Files Coverage Δ
Tests/Internal/ServerSyncProcessHandlerTests.swift 97.56% <88.09%> (+<0.01%) ⬆️
Tests/BeamsTokenProviderTests.swift 84.21% <100.00%> (ø)
Sources/ServerSyncJob.swift 60.82% <0.00%> (-8.25%) ⬇️
Sources/Internal/ServerSyncProcessHandler.swift 80.23% <0.00%> (-1.98%) ⬇️
Tests/RegisterTests.swift 100.00% <0.00%> (ø)
Tests/InterestsTests.swift 100.00% <0.00%> (ø)
Sources/ServerSyncEventHandler.swift 100.00% <0.00%> (ø)
Tests/IntegrationTests/StopTests.swift 100.00% <0.00%> (ø)
Tests/IntegrationTests/SetUserIdTest.swift 100.00% <0.00%> (ø)
Tests/IntegrationTests/ClearAllStateTest.swift 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2755283...fc16cf7. Read the comment docs.

Copy link

@callum-oakley callum-oakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usual disclaimer about me not really knowing swift, but this all looks reasonable to me

@danielrbrowne danielrbrowne merged commit 867c8a6 into master Nov 4, 2020
@danielrbrowne danielrbrowne deleted the fearture/161-spm-improvements branch November 4, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift Package Manager integration improvements
4 participants