Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise 'Source' and 'Test' directories #168

Merged
merged 4 commits into from
Jan 20, 2021

Conversation

danielrbrowne
Copy link
Contributor

This PR resolves #167:

  • Reorganises the Sources and Tests directories to make navigating the project in Xcode much quicker and easier.

@codecov-io
Copy link

codecov-io commented Jan 14, 2021

Codecov Report

Merging #168 (04bd673) into master (de88b30) will decrease coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   89.95%   89.50%   -0.45%     
==========================================
  Files          57       57              
  Lines        2916     2916              
==========================================
- Hits         2623     2610      -13     
- Misses        293      306      +13     
Impacted Files Coverage Δ
Sources/Extensions/Array+CalculateMD5Hash.swift 100.00% <ø> (ø)
Sources/Extensions/Encodable+Encode.swift 100.00% <ø> (ø)
Sources/Extensions/String+HexStringToData.swift 91.66% <ø> (ø)
Sources/Helpers/DeviceTokenHelper.swift 92.30% <ø> (ø)
Sources/Models/AuthData.swift 100.00% <ø> (ø)
Sources/Models/InstanceId.swift 100.00% <ø> (ø)
Sources/Models/Metadata.swift 100.00% <ø> (ø)
Sources/Models/PersistenceConstants.swift 100.00% <ø> (ø)
Sources/Models/PublishId.swift 100.00% <ø> (ø)
Sources/Models/PushNotificationsAPIError.swift 83.33% <ø> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de88b30...04bd673. Read the comment docs.

Copy link

@TomKemp TomKemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know this project well enough to comment on whether this new structure makes sense for the project, but generally the directory names look reasonable 👍

@danielrbrowne danielrbrowne merged commit 472be40 into master Jan 20, 2021
@danielrbrowne danielrbrowne deleted the tech/167-repo-reorganisation branch January 20, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganise source files under the 'Sources' and 'Tests' directories
3 participants