Don't add rbnacl as dependency
#162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some gems, such as `ruby-jwt`, try to load `rbnacl` when library loaded. https://github.com/jwt/ruby-jwt/blob/0f7dd575a3324a4aefe769a1f7d381efe2141771/lib/jwt/signature.rb#L11-L15 Because of this, if `rbnacl` exists in dependencies, cause of `libsodium` load error. Therefore, it is better to have it specified in the user's `Gemfile` instead of making it dependency of gem. Fixes pusher#161.
|
Looks good, thanks for this! |
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some gems, such as
ruby-jwt, try to loadrbnaclwhen library loaded.https://github.com/jwt/ruby-jwt/blob/0f7dd575a3324a4aefe769a1f7d381efe2141771/lib/jwt/signature.rb#L11-L15
Because of this, if
rbnaclexists in dependencies, cause oflibsodiumload error.Therefore, it is better to have it specified in the user's
Gemfileinstead of making it dependency of gem.Fixes #161.