Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] 1.0.0 release #34

Merged
merged 30 commits into from
Jun 14, 2016
Merged

[WIP] 1.0.0 release #34

merged 30 commits into from
Jun 14, 2016

Conversation

hamchapman
Copy link
Contributor

@hamchapman hamchapman commented Apr 3, 2016 •
edited
Loading

  • Split up PusherSwift into multiple files
  • Split up tests into multiple files
  • Bring CryptoSwift, Starscream and Reachability dependencies inside the library
  • Add documentation to code
  • Add onMemberAdded and onMemberRemoved properties to presence channel
  • Add findMember and me functions to presence channel
  • Change connection change delegate based on comments in connectionState is not updated when delegate's method connectionChange is called #50
  • Add ability to have logging for all messages, as in Logging #45
  • Investigate handling client errors better Handle client errors properly #52
  • Clean up cocoapods-related code
  • Check carthage still working
  • Final checks

@hamchapman hamchapman force-pushed the split-up-and-document branch 3 times, most recently from 9e2a3e0 to ee0186a Compare April 7, 2016 09:42
@hamchapman hamchapman mentioned this pull request Apr 25, 2016
Closed
@hamchapman hamchapman changed the title [WIP] Split up PusherSwift.swift into smaller files [WIP] 1.0.0 release May 6, 2016
@hamchapman hamchapman mentioned this pull request May 6, 2016
Closed
@ay8s
Copy link

ay8s commented May 7, 2016

Amazing work @hamchapman. Was just wondering how I could access these. 👍

@hamchapman
Copy link
Contributor Author

@ay8s I've fixed the onMemberAdded related code and added findMember and me functions to the presence channel class. Let me know if it's now working as you'd expect!

@hamchapman
Split up PusherSwift.swift into smaller files
2bc9e12
@hamchapman
Include cutdown version of CryptoSwift directly and remove pod depend…
d0358c2 
…ency
@hamchapman
Remove pod dependency on ReachabilitySwift and Starscream and include…
2c57afb 
… manually
@hamchapman
Split up tests into multiple, logically split files
dde3f78
@hamchapman
Add documentation to all Pusher-specific code
a5f3463
@hamchapman
Added onMemberAdded and onMemberRemoved functions to presence channels.
be194c6 
Tidied up whitespace.

Added licences where appropriate.
@hamchapman
Fix onMemberAdded code and add method for fetching member (including me)
fbc968e 
from presence channel members object.
@hamchapman
Update Quick and Nimble in Podfile
8a108d8
@hamchapman
Use latest Cocoapods RC on Travis.
c875a37 
Remove Cocoapods build steps for non-test targets
@hamchapman
Update CHANGEGLOG in preparation of 1.0.0 release
a27ab96
@hamchapman
Update README with information about presence channel improvements
3566842
@ay8s
Copy link

ay8s commented May 9, 2016

Perfect @hamchapman. Will give it a whirl tonight and let you know if I spot anything. 👍

@ay8s
Copy link

ay8s commented May 10, 2016

Looking good from my end @hamchapman. I wonder if it's possible to make PresenceChannelMember hashable at all? Planning to store PresenceChannelMember's against views/names etc which adding would make super easy!

@hamchapman
Copy link
Contributor Author

hamchapman commented May 10, 2016 •
edited
Loading

Great - @ay8s would you be happy to create a PR for making PresenceChannelMember hashable? It sounds like a good idea but I don't really have the time to do it at the moment :)

@hamchapman
Copy link
Contributor Author

hamchapman commented May 10, 2016 •
edited
Loading

Or is it maybe easier to just make the members array into a dictionary where the keys are user_ids? WDYT @ay8s?

@ay8s
Copy link

ay8s commented May 10, 2016

I think I might be able to simply use the user_id itself rather than need it to be hashable. I'm not running a server so don't quite have any other information in there to use. :)

hamchapman and others added 4 commits May 11, 2016 11:16
@hamchapman
Use cocoapods 1.0.0
1955f82
@psycotica0
Pass Authorization Errors Down to Client
25f2250 
Currently we're just logging the error, but I need that at the client side.
I thought about a delegate, but I figured in this case we have a channel that's
listening to events, so I'll just send an event out.
@hamchapman
Merge pull request #47 from Boltmade/auth_errors
a6f7308 
Pass Authorization Errors Down to Client
@hamchapman
Add test for handling authentication errors
77bd1ea
@hamchapman hamchapman mentioned this pull request Jun 2, 2016
Closed
@hamchapman hamchapman self-assigned this Jun 13, 2016
psycotica0 and others added 4 commits June 13, 2016 12:36
@psycotica0
Dispatch Errors on Main Thread
91b7770 
The other error handlers are called by Starscream's delegate, but the auth
errors are called by NSUrlSession, which is on a background thread.

So, I've moved the logic into a dispatch_async the main thread.
I decided to put it in the handleError method rather than outside it because
there are multiple places that need it and currently all of them are on the
background threads.

If later that's not true, then we should put the dispatch around the method
call in all 4 or so places it comes up.
@psycotica0
Added Tests for Main Thread Auth Error
0547911 
Had to make the test async to have it work, but then it seemed to work.
The expect in the callback feels a little weird, but I think it's alright.
@hamchapman
Merge pull request #49 from Boltmade/auth_errors
fecea27 
Dispatch Errors on Main Thread
@hamchapman
Call state change delegate after setting connection state to new state.
516493d 
Fixes #50
@hamchapman hamchapman merged commit 7caeed2 into master Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hamchapman hamchapman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hamchapman @ay8s @psycotica0