Fix reconnection issue #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
The modification aims to reestablish the connection whenever the
WebSocketConnectionDelegatetriggers thewebSocketDidReceiveErrorevent due to anyPOSIXerror, except forENOTCONN(code 57 - Socket is not connected).Why is the change necessary?
After thorough monitoring, we observed that whenever the
WebSocketConnectionDelegatetriggers thewebSocketDidReceiveErrorevent due to anyPOSIXerror other thanENOTCONN, the socket loses its connection. However, theWebSocketConnectionDelegatefails to call thewebSocketDidDisconnectmethod, leaving the instance in a "connected" state, even though it is effectively disconnected. This situation prevents reconnection attempts, forcing users to restart the app to establish a new connection.