Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library automatically adds RECORD_AUDIO #199

Closed
cheesemcbaguette opened this issue Jul 11, 2019 · 2 comments
Closed

Library automatically adds RECORD_AUDIO #199

cheesemcbaguette opened this issue Jul 11, 2019 · 2 comments

Comments

@cheesemcbaguette
Copy link

cheesemcbaguette commented Jul 11, 2019

Describe the bug
I use the library only to take pictures and the permission RECORD_AUDIO is automatically added to the manifest.

Is there a way to avoid this permission to be added ?

@pvasa
Copy link
Owner

pvasa commented Jul 12, 2019

@florianhirson audio permission in Android requires explicit approval from user. So even if it is added in manifest, it won't be approved by default. You need to ask explicitly for runtime permission.

@pvasa pvasa closed this as completed Jul 18, 2019
@rocca23
Copy link

rocca23 commented Aug 30, 2019

I think it's not the better approach to add all potentially used permission in the library manifest. Apps end up declaring permissions that they don't use and this may be relevant with Android < 6, where users accept permissions upfront. I think you should document what permissions are needed to use the relevant features and leave to developers the declaration of such permissions in their manifest.

For anyone looking into this issue, in the meanwhile you can remove unwanted permission (like the suspicious record audio permission) in this way:

<uses-permission
        android:name="android.permission.RECORD_AUDIO"
        tools:node="remove" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants