Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pandas >= 1.1.0 #82

Closed
wfvining opened this issue Oct 23, 2020 · 2 comments · Fixed by #118
Closed

Support pandas >= 1.1.0 #82

wfvining opened this issue Oct 23, 2020 · 2 comments · Fixed by #118
Labels
dependency Issues relating to dependencies or dependency management
Milestone

Comments

@wfvining
Copy link
Collaborator

Pandas seems to have ironed out the .groupby().rolling() bugs that were introduced in version 1.1.0. Unfortunately, while the two obvious bugs that were initially holding up this change have been fixed, the behavior seems to have changed. In particular these two tests fail at pandas 1.1.3:

  • tests/features/test_daytime.py::test_daytime_split_day
  • tests/features/test_daytime.py::test_daytime_daylight_savings

The output for both classifies some data that is obviously daytime as night. Might still be a pandas bug, but I'm not sure at this point.

@wfvining wfvining added the dependency Issues relating to dependencies or dependency management label Oct 26, 2020
@wfvining
Copy link
Collaborator Author

wfvining commented Nov 9, 2020

Rolling_groupby_gaps

rolling().groupby() in daytime._rolling_by_minute() results in strange gaps near the end of the series. I think this comes up for test_daytime_split_day but not other tests because the gaps are during the night-time periods for the other tests (and comparison with NaN is always False).

@wfvining
Copy link
Collaborator Author

Pandas 1.1.x is apparently still suffering from bugs in .groupby().rolling()

@kandersolar kandersolar added this to the v0.1.1 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Issues relating to dependencies or dependency management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants