Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect higher CGs #43

Closed
RElesgoe opened this issue Jul 5, 2014 · 3 comments
Closed

Respect higher CGs #43

RElesgoe opened this issue Jul 5, 2014 · 3 comments

Comments

@RElesgoe
Copy link
Member

RElesgoe commented Jul 5, 2014

There aren't any checks for many commands to respect users with higher CGs than you. For example, you wouldn't want someone with CG3 to ip ban anyone with CG 4, 5, 6, 7, or 8.
Commands that need these checks:

/voice
/devoice
/chpass
/serverban
/ipban
/kill
/killsession
/lock
/lockacct
/unlock
/unlockacct
/mute
/muteacct
/unmute
/unmuteacct
/set
/commandgroups
/cg
/clearstats
@cen1
Copy link
Collaborator

cen1 commented Jul 5, 2014

Not necessarily. It really depends how the commands are distributed between CGs. We have ban/kill/ip commands on CG7 but we still need them for CG8 ex: killing an admin worker account if it gets stuck online. In general, higher command group number does not mean higher position, just different set of commands.

@HarpyWar
Copy link
Member

HarpyWar commented Jul 5, 2014

I agree with @cen1.
Instead I want to add logging into different files for each user who use commands with cg > 1, so it will be possible to find violators.

But your script can be easily added in Lua in handle_command.lua. I remember it as an example for documentation.

btw, /killsession should be deactivated in command_groups.conf because this command is for debugging.

@RElesgoe
Copy link
Member Author

RElesgoe commented Jul 5, 2014

Logging would be fine I guess. I never figured out how to use /killsession so I'm fine with removing it, we should also consider /addacct too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants