-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible to download the generated icons #1234
Comments
Hello tossnet, thank you for opening an issue with us! I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌 |
Thanks for the bug report. We've found the source of the problem and are working on a fix. |
Adding another related bug to this feature. I've just tested to upload an icon. I can see briefly the various icon images and then it disappears. Steps to repro: 1 - Go on pwabuilder.com You should see them very briefly before it disappears. I'm suspecting a bug in our NUXT backend. |
I'm not entirely sure if we've redeployed the application, but @davrous issue should be resolved. |
Yep! It now works fine. Thanks @lee-leonardo ! |
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com>
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com>
fixes #3586 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type Bugfix ## Describe the current behavior? When you switch pages, the action items pane resizes. ## Describe the new behavior? The pane is now a set height and the todo items are aswell, when you switch pages, everything stays. Only thing is that everything is a bit thicker, but the space feels good. ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com>
fixes #3806 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type Bugfix ## Describe the current behavior? + Describe the new behavior? Described here shoelace-style/shoelace#1185 ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information Thanks to Cory from shoelace Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com>
…kage (#3850) fixes #3849 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type Feature ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> You need to have a SW to package ## Describe the new behavior? You no longer need a SW to package. Todo list sorted by required > highly rec > rec > optional to promote the things we think are important first. ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Justin Willis <jgw9617@gmail.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
…e Worker Requirement (#3857) fixes #3853 and #3849 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type Features ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> 1. Action items do not show at all until all tests are done running 2. You are required to have a service worker to package. ## Describe the new behavior? 1. Action items populate the todo list as they come in from their respective tests completing. 2. The service worker doesn't need to be present to package. ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Justin Willis <jgw9617@gmail.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
fixes #3873 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type Feature <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> If you didn't have widgets, you were still able to check the box in the windows form saying to serve widgets for your package which changes the way the .msix is built unnecessarily. ## Describe the new behavior? You can only toggle the widgets checkbox if you already have widgets in your manifest. Otherwise, it'll be disabled. ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> Documentation content changes <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? Same words were repeated twice. ## Describe the new behavior? Repeated words have been erased. ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
fixes #3871 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> Other... Please describe: Analytics ## Describe the new behavior? SessionID is now sent in our analytics + sent to the pwabuilder services as a header ## PR Checklist - [ x] Test: run `npm run test` and ensure that all tests pass - [x ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com>
fixes #3747 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Shortcuts snippet did not include icons array, which is technically invalid, although it would work in the browser (using the apps icon instead, automagically by the browser) ## Describe the new behavior? Shortcuts snippet now includes icon array. We now build the shortcuts snippet from an array to avoid frustrating syntax with vscode snippets ## PR Checklist - [ x] Test: run `npm run test` and ensure that all tests pass - [x ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com>
…on in the packaging form (#3892) fixes #3861 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type Bugfix / Feature <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Right now, we use the developers `manifest.background_color` as a default and `"transparent"` as a fallback for the Windows icon background color. ## Describe the new behavior? Now we have a color pick in the windows packaging form that gives the developer complete control over that field. ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information This PR contains some other minor bug fixes and updates to the way we use the `sl-select` component as it was rewritten by shoelace recently. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Justin Willis <jgw9617@gmail.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
…ss all forms (#3925) fixes #3898 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type Feature ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> I originally created a new color picker option in the Windows packaging form for the Icon background color. I then realized that the android and ios forms also use color pickers and things were not uniform. ## Describe the new behavior? I created a generic color picker that can just be used by calling the same `renderFormInput` still with `type='color'` and the new color picker will be generated for all forms. ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information This is what it looks like: ![image](https://user-images.githubusercontent.com/51131738/227971177-ada7b3e6-961f-4f9d-9ff7-ddb5df9d436b.png)
fixes documentation for android nav color description <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> Documentation content changes <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Documentation for android nav color description is wrong. ## Describe the new behavior? Documentation for android nav color description is no longer wrong. ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Justin Willis <jgw9617@gmail.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com>
fixes #4241 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Our blackicons (svgs embedded in imgs) weren't changing color when dark mode was activated on the OS level. So they were blending in to the background (black on black). ## Describe the new behavior? When dark mode is detected, our black icons become white. ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Justin Willis <jgw9617@gmail.com>
…cs and PWABuilder.com (#4478) fixes #4232 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? View problem in issue. ## Describe the new behavior? Each page has an H1 and proper headings underneath. Certain text that acted as headers but weren't technically headers are now headers in the HTML. ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information This is a joint PR of the work from both myself and @zateutsch --------- Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: Beth Pan <xupa@microsoft.com>
fixes #4157 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> As the user showed in the issue, it is possible to get into a state where `getManifest` returns nothing, which would cause the generated manifest to not be linked to the index.html. ## Describe the new behavior? We now pass the manifestPath directly as a "backup" value, which would avoid any, unlikely, breakage as it is just a backup value to how things normally work. ## PR Checklist - [x ] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com>
fixes #4374 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> We were only checking for PNG icons, but as the user pointed out, SVG is supported too. ## Describe the new behavior? Updated the test to check for either PNG or SVG, along with updating the test message to reflect this change. ## PR Checklist - [ x] Test: run `npm run test` and ensure that all tests pass - [ x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
…4508) fixes #4504, #4474 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix Feature <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> 1. No current support for Offline Support 2. No current separation of Security Tests 3. html`` being returned in ternary operators instead of null 4. The red icon inside the filter button in the action items list changes sizes when clicked to become active. 5. Cannot tab inside the tooltips (Community, SW and Manifest tooltips) 6. Upon pressing the retest button, the app capabilities score weren't resetting. ## Describe the new behavior? 1. Offline support inside the SW card 2. New Security warning when delivering mixed content. Can package with warning. 3. return null where it makes sense instead of html`` 4. Icon stays the same size. 5. Can now use arrow keys to get inside tooltips to the links (learn more, edit in manifest, or the community links) 6. App Capabilities score now resets properly ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Beth Pan <xupa@microsoft.com>
fixes #4531 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> Build or CI related changes <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Tests were failing because of the issue described in the linked bug. ## Describe the new behavior? Tests have been updated to: - account for the `visually-hidden` text - properly wait on the tests to pass before testing to see if the package button is disabled or not ## PR Checklist - [x ] Test: run `npm run test` and ensure that all tests pass - [ xTarget main branch (or an appropriate release branch if appropriate for a bug fix) - [x ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Beth Pan <xupa@microsoft.com>
fixes #4413 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> Other... Please describe: Blogpost ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information This was originally a different PR targeting staging (#4505) --------- Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com>
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com> Co-authored-by: Thomas Peißl <7underlines@gmail.com>
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> Build or CI related changes <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the new behavior? Staging pipeline for blog ## PR Checklist - [x ] Test: run `npm run test` and ensure that all tests pass - [x ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
Added Node env variable for staging. fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
fixes #4401 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> Feature <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Manifest background color is default for icon background ## Describe the new behavior? Transparent is default for icon background ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information This PR also disables the ability to generate screenshots as we feel generating base64 strings into peoples manifest is creating an inefficient system and people don't understand why its inefficient and trusting that PWABuilder is doing the right thing when it isn't. Part of the temporary solution described here #4550
Added node_env in production workflow fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information Co-authored-by: Justin Willis <jgw9617@gmail.com>
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com> Co-authored-by: Thomas Peißl <7underlines@gmail.com>
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Justin Willis <jgw9617@gmail.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com> Co-authored-by: Thomas Peißl <7underlines@gmail.com>
fixes #4382 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> Feature <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Options in old order ## Describe the new behavior? Options in new order ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Justin Willis <jgw9617@gmail.com>
fixes [#4483](#4483), #4482, #4484 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> Feature <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Old nav just leads to docs and github No author profile tag list is clutter and has redundant tags ## Describe the new behavior? New nav matches that of pwabuilder.com Author profile section exists now tag list is clean and has intentional categories ## PR Checklist - [x] Test: run `npm run test` and ensure that all tests pass - [x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com>
fixes #4624 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> We were calling the old Windows packaging service. ## Describe the new behavior? We are now calling the new Windows service ## PR Checklist - [ x] Test: run `npm run test` and ensure that all tests pass - [ x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
fixes #4635 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> - Documentation content changes <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? Replace typo "doucument" with "document" ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
fixes #4631 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> Other... : Compliance ## Describe the new behavior? New link in our footer ## PR Checklist - [x ] Test: run `npm run test` and ensure that all tests pass - [x ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com> Co-authored-by: Thomas Peißl <7underlines@gmail.com> Co-authored-by: Migush <Migushthe2nd@users.noreply.github.com> Co-authored-by: Abdullhakim Sami Alshanqity <132011567+abdullhakim-sami@users.noreply.github.com> Co-authored-by: mecmep <69386369+mecmep@users.noreply.github.com> Co-authored-by: Joel Limberg <me@joellimberg.com>
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com>
fixes #4728 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> Feature <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the new behavior? Whisper starter has been added as a starter option ## PR Checklist - [x ] Test: run `npm run test` and ensure that all tests pass - [ x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com>
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
fixes - #4763 - #4748 - #4783 - #4747 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com> Co-authored-by: Thomas Peißl <7underlines@gmail.com> Co-authored-by: Migush <Migushthe2nd@users.noreply.github.com> Co-authored-by: Abdullhakim Sami Alshanqity <132011567+abdullhakim-sami@users.noreply.github.com> Co-authored-by: mecmep <69386369+mecmep@users.noreply.github.com> Co-authored-by: Joel Limberg <me@joellimberg.com> Co-authored-by: Pratik-k <prakar57@gmail.com> Co-authored-by: Maicon Carraro <maicon315@gmail.com>
fixes #4743 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> When the input was autofilled, the color was a bright blue that did not have good contrast. ## Describe the new behavior? It now uses our standard input color. ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com> Co-authored-by: Thomas Peißl <7underlines@gmail.com> Co-authored-by: Migush <Migushthe2nd@users.noreply.github.com> Co-authored-by: Abdullhakim Sami Alshanqity <132011567+abdullhakim-sami@users.noreply.github.com> Co-authored-by: mecmep <69386369+mecmep@users.noreply.github.com> Co-authored-by: Joel Limberg <me@joellimberg.com> Co-authored-by: Pratik-k <prakar57@gmail.com> Co-authored-by: Maicon Carraro <maicon315@gmail.com>
fixes #[issue number] <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> <!-- - Bugfix --> <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> ## Describe the new behavior? ## PR Checklist - [ ] Test: run `npm run test` and ensure that all tests pass - [ ] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ ] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Beth Pan <xupa@microsoft.com> Co-authored-by: Gleb Khmyznikov <gleb.khmyznikov@gmail.com> Co-authored-by: Jaylyn Barbee <jaylyn.1b@gmail.com> Co-authored-by: Jaylyn Barbee <51131738+Jaylyn-Barbee@users.noreply.github.com> Co-authored-by: Nikola Metulev <nmetulev@users.noreply.github.com> Co-authored-by: Mara'ah Lee <maraahlee@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adolf Daniel <10156724+adolfdaniel@users.noreply.github.com> Co-authored-by: Justin Willis (HE / HIM) <juwillis@microsoft.com> Co-authored-by: Zach Teutsch <88554871+zateutsch@users.noreply.github.com> Co-authored-by: vipul-bhojwani <67650372+vipul-bhojwani@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amrutha.srinivasan95@gmail.com> Co-authored-by: Federico Navarrete <darklord.navarrete@gmail.com> Co-authored-by: Toby Liu <ybot1122@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Amrutha Srinivasan <amsrin@microsoft.com> Co-authored-by: Jonas Thelemann <e-mail@jonas-thelemann.de> Co-authored-by: Siraj Chokshi <19193347+SirajChokshi@users.noreply.github.com> Co-authored-by: Thomas Peißl <7underlines@gmail.com> Co-authored-by: Migush <Migushthe2nd@users.noreply.github.com> Co-authored-by: Abdullhakim Sami Alshanqity <132011567+abdullhakim-sami@users.noreply.github.com> Co-authored-by: mecmep <69386369+mecmep@users.noreply.github.com> Co-authored-by: Joel Limberg <me@joellimberg.com> Co-authored-by: Pratik-k <prakar57@gmail.com> Co-authored-by: Maicon Carraro <maicon315@gmail.com>
fixes #4823 <!-- Link to relevant issue (for ex: "fixes #1234") which will automatically close the issue once the PR is merged --> ## PR Type <!-- Please uncomment one ore more that apply to this PR --> Bugfix <!-- - Feature --> <!-- - Code style update (formatting) --> <!-- - Refactoring (no functional changes, no api changes) --> <!-- - Build or CI related changes --> <!-- - Documentation content changes --> <!-- - Sample app changes --> <!-- - Other... Please describe: --> ## Describe the current behavior? <!-- Please describe the current behavior that is being modified or link to a relevant issue. --> Service was broken, unfortunately I must be light on details here. ## Describe the new behavior? Pointing to our new instance of the main test service. ## PR Checklist - [x ] Test: run `npm run test` and ensure that all tests pass - [ x] Target main branch (or an appropriate release branch if appropriate for a bug fix) - [ x] Ensure that your contribution follows [standard accessibility guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design). Use tools like https://webhint.io/ to validate your changes. ## Additional Information
After sending a 512x512 image and all formats are generated. It is impossible to upload them. Clicking on the button has no effect.
Additional info :
The text was updated successfully, but these errors were encountered: