Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error generating androidTWA package: failed to download icon #1365

Closed
MrVibe opened this issue Jan 13, 2021 · 7 comments
Closed

Error generating androidTWA package: failed to download icon #1365

MrVibe opened this issue Jan 13, 2021 · 7 comments

Comments

@MrVibe
Copy link

MrVibe commented Jan 13, 2021

I received the following error when generating a package for https://amarclassonline.com/classroom/

Error generating Android package.

Status code: 500

Error: Internal Server Error

Details: Error generating app package: Error: Failed to download icon https://amarclassonline.com/wp-content/uploads/icon-512x512.png. Responded with status 403

@ghost ghost added the needs triage 🔍 label Jan 13, 2021
@ghost
Copy link

ghost commented Jan 13, 2021

Hello MrVibe, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will investigate the issue and help solve it ASAP. Other community members may also look into the issue and provide feedback 🙌

@JudahGabriel JudahGabriel changed the title Error generating androidTWA package Error generating androidTWA package: failed to download icon Jan 14, 2021
@JudahGabriel
Copy link
Contributor

I ran https://amarclassonline.com through PWABuilder, but it looks like you're missing both a manifest and a service worker. Is that correct?

@davrous
Copy link
Contributor

davrous commented Jan 14, 2021

The manifest & PWA is there on https://amarclassonline.com/classroom/ pointing to https://amarclassonline.com/wp-content/uploads/icon-512x512.png for the 512x512 which I can load from the browser but no SW indeed.

@MrVibe
Copy link
Author

MrVibe commented Jan 15, 2021

Nope, you have to visit the link : https://amarclassonline.com/classroom/ , for the service worker to get active on the site. USe the url : https://amarclassonline.com/classroom/ for generating the app and you'll see

the manifest is generated : https://amarclassonline.com/manifest.json and the service worker is this : https://amarclassonline.com/firebase-messaging-sw.js?v=1.5.1.0

@JudahGabriel
Copy link
Contributor

JudahGabriel commented Jan 19, 2021

Hi @MrVibe,

The issue is that your web server is blocking access to PWABuilder's Android dev tools. Specifically, the follow URL instructs our dev tools to download your 512x512 image. It should return the image. Instead, it's returning 403 Forbidden:

https://pwabuilder-cloudapk.azurewebsites.net/fetch?type=blob&url=https://amarclassonline.com/wp-content/uploads/icon-512x512.png

We had fixed this a week or two ago, but only for errors that were returning CONNECTION REFUSED, which is why you are still hitting the problem. I'm filing a fix for this now.

In the meantime, here's a workaround:

In PWABuilder, when you go to download your Android package, click Options, and change the following values:

Click Done, then click Download. Your Android package will be generated successfully. Give it a try and let us know.

@davrous
Copy link
Contributor

davrous commented Jan 25, 2021

We've got a workaround using the pwabuilder safe url redirect and the fix will be soon deployed to production. Closing the issue. Thanks for helping us improving the project!

@davrous davrous closed this as completed Jan 25, 2021
@MrVibe
Copy link
Author

MrVibe commented Jan 26, 2021

Yes, thank you. Confirming the issue is resolved.

jgw96 added a commit that referenced this issue Jan 28, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this issue Feb 10, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this issue Mar 11, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this issue Mar 24, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this issue Mar 25, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2021
jgw96 added a commit that referenced this issue Mar 30, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

* Fixes #1474, screenshots have correct sizes (#1577)

* Fixes #1570, language selection values (#1579)

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this issue Apr 19, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

* Fixes #1474, screenshots have correct sizes (#1577)

* Fixes #1570, language selection values (#1579)

* Better screenshots #1474 (#1589)

* chore(): update samsung platform to reflect changes

* Completed Samsung UI update

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Justin Willis <jgw9617@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this issue May 3, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

* Fixes #1474, screenshots have correct sizes (#1577)

* Fixes #1570, language selection values (#1579)

* Better screenshots #1474 (#1589)

* chore(): update samsung platform to reflect changes

* Completed Samsung UI update

* chore(): update action based on findings from api v2

PRs are now handled specifically for both dev and prod

* Update link to IARC rating ID (#1657)

* Added offline check fallback (#1660)

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Justin Willis <jgw9617@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
Co-authored-by: Steven Sinatra <5153378+diagramatics@users.noreply.github.com>
jgw96 added a commit that referenced this issue May 3, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

* Fixes #1474, screenshots have correct sizes (#1577)

* Fixes #1570, language selection values (#1579)

* Better screenshots #1474 (#1589)

* chore(): update samsung platform to reflect changes

* Completed Samsung UI update

* chore(): update action based on findings from api v2

PRs are now handled specifically for both dev and prod

* Update link to IARC rating ID (#1657)

* Added offline check fallback (#1660)

* fix(): action runs on merges to prod

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
Co-authored-by: Steven Sinatra <5153378+diagramatics@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants