Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update featured.json #1295

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Update featured.json #1295

merged 2 commits into from
Dec 14, 2020

Conversation

r0mankon
Copy link

Fix a typo!

Fixes #

PR Type

Describe the current behavior?

Describe the new behavior?

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target master branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@ghost
Copy link

ghost commented Dec 13, 2020

Thanks rokonxr for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned JudahGabriel Dec 13, 2020
@jgw96 jgw96 changed the base branch from master to dev December 14, 2020 21:33
@jgw96
Copy link
Contributor

jgw96 commented Dec 14, 2020

Thank you @rokonxr ! Much appreciated

@jgw96 jgw96 merged commit f23bed5 into pwa-builder:dev Dec 14, 2020
jgw96 added a commit that referenced this pull request Jan 11, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this pull request Jan 28, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this pull request Feb 10, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this pull request Mar 11, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this pull request Mar 24, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this pull request Mar 25, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this pull request Mar 30, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

* Fixes #1474, screenshots have correct sizes (#1577)

* Fixes #1570, language selection values (#1579)

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this pull request Apr 19, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

* Fixes #1474, screenshots have correct sizes (#1577)

* Fixes #1570, language selection values (#1579)

* Better screenshots #1474 (#1589)

* chore(): update samsung platform to reflect changes

* Completed Samsung UI update

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Justin Willis <jgw9617@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
jgw96 added a commit that referenced this pull request May 3, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

* Fixes #1474, screenshots have correct sizes (#1577)

* Fixes #1570, language selection values (#1579)

* Better screenshots #1474 (#1589)

* chore(): update samsung platform to reflect changes

* Completed Samsung UI update

* chore(): update action based on findings from api v2

PRs are now handled specifically for both dev and prod

* Update link to IARC rating ID (#1657)

* Added offline check fallback (#1660)

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Justin Willis <jgw9617@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
Co-authored-by: Steven Sinatra <5153378+diagramatics@users.noreply.github.com>
jgw96 added a commit that referenced this pull request May 3, 2021
* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* PWABuilder MacOS v2 (#1286)

* env change

* added macos platform code usage, need to work through a CORS issue.

* zipAll from axios to fetch (#1289)

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Refactored score cards. Added additional checks.

* Added service worker fallback (#1284)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* fix(): small typescript error

* chore(): update docker container to node 12

* Update featured.json (#1295)

Fix a typo!

Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>

* Casing fix. Removed unused CSS build warnings

* Fix for build (#1306)

* Added service worker fallback

* Fix comment, added missing await

* Moving offline check into separate proc

* Refactored score cards. Added additional checks.

* Casing fix. Removed unused CSS build warnings

* fix(): sw picker form has min-height to avoid "pop-in"

* refactor(): move to new service worker server + simplify

* v2 web packaging (#1301)

* v2 web packaging

* for documentation sake, but something for the future

* new endpoints

Co-authored-by: Justin Willis <jgw9617@gmail.com>

* Added safe URL fetching fallback (#1315)

* Added safe URL fetching fallback

* Better service name

* Fix for #1336 (#1344)

* Initial work towards nav fix

* Added UI for Play billing, location delegation (#1346)

* Final fix for edit manifest nav

* Fixes #1365 (#1380)

* Additional windows platform fields (#1448)

* Adds package language and start_url to Windows

* I'm writing TS, not C#

* Fixed label name collision

* Removed redis sync.

* chore(): remove deprecated legacy edge platform

* Fixes #1546 (#1558)

* Fixes #1474, screenshots have correct sizes (#1577)

* Fixes #1570, language selection values (#1579)

* Better screenshots #1474 (#1589)

* chore(): update samsung platform to reflect changes

* Completed Samsung UI update

* chore(): update action based on findings from api v2

PRs are now handled specifically for both dev and prod

* Update link to IARC rating ID (#1657)

* Added offline check fallback (#1660)

* fix(): action runs on merges to prod

Co-authored-by: Judah Gabriel Himango <judahgabriel@gmail.com>
Co-authored-by: Leonardo Lee <lee.leonardo.king@gmail.com>
Co-authored-by: Roman Rokon <rokon.rxr@gmail.com>
Co-authored-by: Steven Sinatra <5153378+diagramatics@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants