-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose gyro data via all interfaces and validate #20
Comments
The combination of gyro angular rate and non-motion compensated optical flow rates (optical flow in rad/second) are very useful for fusion of this data in an external observer. This enables an external observer to: a) estimate focal length scale factor error |
This gyro data should be averaged using the same sample set that is used for the px4flow measurements. What I mean by this is that if there are invalid flow measurements that are not being averaged, the gyro data corresponding to those flow measurements should also not be included in the gyro average. |
I hacked the px4flow master code to output the averaged gyro rates and flew it this weekend. https://groups.google.com/d/msg/drones-discuss/SqgXeojbiZU/WcFo2KNWCYsJ The improvement in performance was significant |
@dominiho The change set has been dangling for a while now, and I think we should try to wrap this up, since it doesn't seem to be major effort. @priseborough is there a chance to consolidate your patch with the current master here so we can get your changes across? We also need to sync with respect to #21. |
I think it would be best to work through the patch interactively with with someone on your team. Happy to schedule in a Skype meeting when it suits. |
@dominiho The scale factor here does not match the data sheet: Thanks @priseborough for reporting and @tridge for working the code location out. |
This here doesn't quite make sense according to the data sheet - there is only 250/500/2000 selectable range.
The three scaling factors should be:
|
The temperature status is in register 0x26, so trivial to add there. |
i don't think the table in https://github.com/PX4/Flow/blob/master/src/gyro.c#L56 is affecting the integrated outputs. It looks like the scale factor applied is being calculated here: |
Yes, and that line pulls from the table ;-) |
M_PI_F (or a constant with 7-8 digits after the decimal point) should be used here instead: |
We should expose all gyro data and cross-check that rates and readout speed make sense. We should also include a flag to indicate wether the gyro data is available (in case we want to remove the sensor later if we conclude its not useful).
The text was updated successfully, but these errors were encountered: