Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme links wrong #19

Closed
huayunh opened this issue Oct 11, 2021 · 4 comments · Fixed by #20
Closed

Readme links wrong #19

huayunh opened this issue Oct 11, 2021 · 4 comments · Fixed by #20
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something isn't working docs Improvements or additions to documentation good first issue A good issue for first-time contributors needs-review Issues that we would like to revisit/review

Comments

@huayunh
Copy link
Contributor

huayunh commented Oct 11, 2021 •
edited
Loading

Describe the bug

Image links in Readmes, like this and this, are currently pointing to our deprecated old repository.

They need to be fixed and look good from both GitHub and NPM.
@huayunh huayunh added bug Something isn't working good first issue A good issue for first-time contributors needs-review Issues that we would like to revisit/review docs Improvements or additions to documentation labels Oct 11, 2021
@tpmai22
Copy link
Contributor

tpmai22 commented Oct 13, 2021

I would love to know a bit more so I have enough knowledge to work on this

@huayunh
Copy link
Contributor Author

huayunh commented Oct 13, 2021

My bad. I rephrased it a little — see if this helps.

@tpmai22
Copy link
Contributor

tpmai22 commented Oct 13, 2021

I got it let see what I can do with it

@tpmai22 tpmai22 mentioned this issue Oct 13, 2021
Merged
@tpmai22
Copy link
Contributor

tpmai22 commented Oct 13, 2021

I just made a pr, please kindly let me know if my changes are correct !

@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something isn't working docs Improvements or additions to documentation good first issue A good issue for first-time contributors needs-review Issues that we would like to revisit/review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change deprecated image links follow issue-19 tpmai22/progress-icons
3 participants
@huayunh @joebochill @tpmai22