-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table header action now extends Filament\Actions\Action #132
Comments
The merged PR #133 breaks the code if you're adding a header option directly to the table function in the resource like this
with version 2.1.7 throws exception "Method pxlrbt\FilamentExcel\Actions\Tables\ExportAction::table does not exist." |
Yes, it seems to be broken.
return $table
->columns([...])
->headerActions([
\pxlrbt\FilamentExcel\Actions\Tables\ExportAction::make('myexportaction')->exports([
// export logic
]),
]); Pull request #133 should be reverted. |
Thanks for confirming. I just reverted the PR. |
@saulens22 Thanks for pointing out that the wrong Action was used. |
Sorry for the problem, that was not my intension. I tried the |
Following the documentation for Actions\Tables\ExportAction for table header actions, this now throws an exception in Filament v3
This now throws an exception:
The fix is to update pxlrbt/filament-excel/src/Actions/Tables/ExportAction.php
The export action then works as expected.
The text was updated successfully, but these errors were encountered: