pdf.image() doesn't allow file names starting with 'data'

[1nv]

Error details

When trying to call pdf.image() with filename starting with 'data', an error occurs:

imageData = base64Image.split("base64,")[1]
IndexError: list index out of range

This is caused by treating anything starting with 'data' as base64 string (see load_image() with elif filename.startswith("data"): check), but some file paths might also start with those characters.

Minimal code

from fpdf import FPDF

pdf = FPDF()
pdf.image('data/image.png', x=0, y=0, w=10, h=10)

Environment

• Operating System: Windows 10
• Python version: 3.10.11
• fpdf2 version used: 2.7.4

[Lucas-C]

Hi @1nv and thank you for reporting this.

I started taking a look at this in #796

Would it be OK for you if we checked for the data: prefix instead of just data?

[Lucas-C]

@allcontributors please add @1nv for bug

[allcontributors]

@Lucas-C

I've put up a pull request to add @1nv! 🎉

[1nv]

Hi @Lucas-C,

Would it be OK for you if we checked for the data: prefix instead of just data?

Yes, that's exactly what I was thinking of, since : is not a valid character for paths (except for drive letters on Windows and mount points on one other platform).

EDIT: I just checked, and it is still valid on Unix/Linux. But this should still be fine, I think.

[Lucas-C]

Yes, that's exactly what I was thinking of, since : is not a valid character for paths (except for drive letters on Windows and mount points on one other platform).

Thanks for your feedback

I merged #796

It is not released yet, but you can install the latest version of fpdf2 straight from git this way:

pip install git+https://github.com/PyFPDF/fpdf2.git@master

If you can test it @1nv I'd be happy to know if that solved your issue 😊

[1nv]

I just tested the way you said, and it works fine!
Thank you for the quick fix!