-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror function #783
Mirror function #783
Conversation
@Lucas-C Mirror transformations with |
@allcontributors please add @sebastiantia fro code |
I've put up a pull request to add @sebastiantia! 🎉 |
The good news is that cells get perfectly well mirrored with your code! 😊 You just need to reset the |
Ahh that explains it. Thanks for the detailed code suggestions and review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made you some final comments.
Once you have answered / addressed them,
I'll be happy to merge this nicePR!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #783 +/- ##
==========================================
+ Coverage 93.26% 93.29% +0.02%
==========================================
Files 27 27
Lines 7324 7348 +24
Branches 1328 1329 +1
==========================================
+ Hits 6831 6855 +24
- Misses 308 309 +1
+ Partials 185 184 -1
☔ View full report in Codecov by Sentry. |
Merged! Thank you very much @sebastiantia for your contribution! 👍 |
I forgot to recommend having a unit test for the case where The new documention section will appear there in a few minutes: I hope you enjoyed contributing to |
Thanks again for all the help and opportunity :) |
Implements mirror function addressing issue #536
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint
(static code analyzer) andblack
(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/
folderA mention of the change is present in
CHANGELOG.md
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.