Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Accept inline images with space before EI #1552

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

pubpub-zz
Copy link
Collaborator

closes #1541

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Base: 91.79% // Head: 91.84% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (c81470f) compared to base (767047b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1552      +/-   ##
==========================================
+ Coverage   91.79%   91.84%   +0.04%     
==========================================
  Files          33       33              
  Lines        6093     6104      +11     
  Branches     1200     1205       +5     
==========================================
+ Hits         5593     5606      +13     
+ Misses        323      322       -1     
+ Partials      177      176       -1     
Impacted Files Coverage Δ
pypdf/generic/_data_structures.py 90.40% <100.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

test to be added

@pubpub-zz
Copy link
Collaborator Author

all good now 😊

@MartinThoma MartinThoma changed the title ENH : accept inline images with space before EI ENH: Accept inline images with space before EI Jan 16, 2023
@MartinThoma MartinThoma merged commit df90053 into py-pdf:main Jan 16, 2023
MartinThoma added a commit that referenced this pull request Jan 22, 2023
New Features (ENH):
-  Add page label support to PdfWriter (#1558)
-  Accept inline images with space before EI (#1552)
-  Add circle annotation support (#1556)
-  Add polygon annotation support (#1557)
-  Make merging pages produce a deterministic PDF (#1542, #1543)

Bug Fixes (BUG):
-  Fix error in cmap extraction (#1544)
-  Remove erroneous assertion check (#1564)
-  Fix dictionary access of optional page label keys (#1562)

Robustness (ROB):
-  Set ignore_eof=True for read_until_regex (#1521)

Documentation (DOC):
-  Paper size (#1550)

Developer Experience (DEV):
-  Fix broken combination of dependencies of docs.txt
-  Annotate tests appropriately (#1551)

[Full Changelog](3.2.1...3.3.0)
@pubpub-zz pubpub-zz deleted the ISS_1541 branch June 24, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression extracting data from PDF: Unexpected end of stream
2 participants