-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add circle annotation support #1556
Conversation
Codecov ReportBase: 91.86% // Head: 91.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
=======================================
Coverage 91.86% 91.87%
=======================================
Files 33 33
Lines 6124 6130 +6
Branches 1208 1210 +2
=======================================
+ Hits 5626 5632 +6
Misses 322 322
Partials 176 176
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@pubpub-zz / @MasterOdin Should we call it "ellipse" instead of circle? (similar to the fact that we called it "square" instead of rectangle? https://pypdf.readthedocs.io/en/latest/modules/AnnotationBuilder.html#pypdf.generic.AnnotationBuilder.rectangle |
ellipse is more consistent with rectangle. we must not forget the note: |
I agree that All circles are ellipses, but not all ellipses are circles. |
New Features (ENH): - Add page label support to PdfWriter (#1558) - Accept inline images with space before EI (#1552) - Add circle annotation support (#1556) - Add polygon annotation support (#1557) - Make merging pages produce a deterministic PDF (#1542, #1543) Bug Fixes (BUG): - Fix error in cmap extraction (#1544) - Remove erroneous assertion check (#1564) - Fix dictionary access of optional page label keys (#1562) Robustness (ROB): - Set ignore_eof=True for read_until_regex (#1521) Documentation (DOC): - Paper size (#1550) Developer Experience (DEV): - Fix broken combination of dependencies of docs.txt - Annotate tests appropriately (#1551) [Full Changelog](3.2.1...3.3.0)
See #107