Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper size #1550

Merged
merged 10 commits into from
Jan 19, 2023
Merged

Paper size #1550

merged 10 commits into from
Jan 19, 2023

Conversation

SandroPanchame
Copy link
Contributor

added examples on how to use the PaperSize class.

I'm not sure what went wrong with the last request.

A6 = Dimensions(298, 420) # Post cards
A7 = Dimensions(210, 298)
A8 = Dimensions(147, 210)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you undo the changes in this file, we can merge it (you can just apply black and make another commit)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have undone the changes to the file and pushed them onto the fork. Is there anything else I may need to do?

@MartinThoma MartinThoma merged commit e6500f8 into py-pdf:main Jan 19, 2023
@MartinThoma
Copy link
Member

Thank you for the PR 🤗

MartinThoma added a commit that referenced this pull request Jan 22, 2023
New Features (ENH):
-  Add page label support to PdfWriter (#1558)
-  Accept inline images with space before EI (#1552)
-  Add circle annotation support (#1556)
-  Add polygon annotation support (#1557)
-  Make merging pages produce a deterministic PDF (#1542, #1543)

Bug Fixes (BUG):
-  Fix error in cmap extraction (#1544)
-  Remove erroneous assertion check (#1564)
-  Fix dictionary access of optional page label keys (#1562)

Robustness (ROB):
-  Set ignore_eof=True for read_until_regex (#1521)

Documentation (DOC):
-  Paper size (#1550)

Developer Experience (DEV):
-  Fix broken combination of dependencies of docs.txt
-  Annotate tests appropriately (#1551)

[Full Changelog](3.2.1...3.3.0)
@xilopaint
Copy link
Contributor

@MartinThoma @SandroPanchame the examples contain PyPDF2 as the module name instead of pypdf.

@MartinThoma
Copy link
Member

Thank you @xilopaint - #1573

MartinThoma added a commit that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants