Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: remove_images not operating in sub level forms #2133

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

pubpub-zz
Copy link
Collaborator

closes #2103

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (fe2dfaf) 94.10% compared to head (7dcd01a) 94.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2133      +/-   ##
==========================================
+ Coverage   94.10%   94.13%   +0.03%     
==========================================
  Files          41       41              
  Lines        7460     7465       +5     
  Branches     1474     1473       -1     
==========================================
+ Hits         7020     7027       +7     
+ Misses        274      273       -1     
+ Partials      166      165       -1     
Files Changed Coverage Δ
pypdf/_writer.py 87.84% <100.00%> (+0.21%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
all yours

@MartinThoma MartinThoma merged commit 7c23cbb into py-pdf:main Aug 31, 2023
14 checks passed
@MartinThoma
Copy link
Member

Very nice! Thank you 🙏

MartinThoma added a commit that referenced this pull request Sep 3, 2023
## What's new

### Bug Fixes (BUG)
-  Cope with missing /I in articles (#2134)
-  Fix image look-up table in EncodedStreamObject (#2128)
-  remove_images not operating in sub level forms (#2133)

### Robustness (ROB)
-  Cope with damaged PDF (#2129)

### Documentation (DOC)
-  How to take ownership (#2123)

### Developer Experience (DEV)
-  Download PDFs before executing the tests to not run into timeouts (#2143)
-  Add workflow_dispatch to CI (#2145)
-  Automatically create release message / tag message (#2127)
-  Ensure the REL commit message is consistently created (#2126)

### Testing (TST)
-  Add test for correct rendering of watermarks (#2130)

[Full Changelog](3.15.4...3.15.5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some images in pdf can not be removed using 'remove_images()'
2 participants