BUG: Cope with missing /I in articles #2134
Conversation
MartinThoma
changed the title
MartinThoma
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2134 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 41 41
Lines 7467 7467
Branches 1474 1474
=======================================
Hits 7029 7029
Misses 273 273
Partials 165 165
☔ View full report in Codecov by Sentry. |
|
@MartinThoma |
|
Maybe a timeout of 4 seconds is just too tight ... |
Your comment identifying the loading as a possible source of discrepancy sounds reasonable. Measuring the time of the water_marking may be more reliable |
|
When measuring the time of the actual process, you might still want a general test method timeout to stop on too long watermarking time. |
the code is not currently failing in infinite loop but you just want to confirm the acceleration is still present. That's why I thing measuring time just around the merge will be more consistent 🙂 |
|
#2143 was done to help with the flaky tests. Please let me know when/if that occurs again. I know that flaky tests are super annoying and I want to ensure that improving pypdf is as fun as possible :-) |
MartinThoma
added
the
soon
MartinThoma
removed
the
soon
## What's new ### Bug Fixes (BUG) - Cope with missing /I in articles (#2134) - Fix image look-up table in EncodedStreamObject (#2128) - remove_images not operating in sub level forms (#2133) ### Robustness (ROB) - Cope with damaged PDF (#2129) ### Documentation (DOC) - How to take ownership (#2123) ### Developer Experience (DEV) - Download PDFs before executing the tests to not run into timeouts (#2143) - Add workflow_dispatch to CI (#2145) - Automatically create release message / tag message (#2127) - Ensure the REL commit message is consistently created (#2126) ### Testing (TST) - Add test for correct rendering of watermarks (#2130) [Full Changelog](3.15.4...3.15.5)
closes #2089