DEV: Download PDFs before executing the tests to not run into timeouts #2143
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2143 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 41 41
Lines 7467 7467
Branches 1474 1474
=======================================
Hits 7029 7029
Misses 273 273
Partials 165 165 ☔ View full report in Codecov by Sentry. |
|
@pubpub-zz What do you think about this? |
|
Sounds quite good, but are you sure the coverage will not slow down process in a random way ? You may think a conservative guy, but mixing time-outs (to prevent infinite loops) and performances is not so nice 🫤 |
No, I'm not. But I think compared to the download-time (especially if the internet connection might be flaky or the server might be down) the impact of that should be negligible. I'll merge it for now and will expand it over time in hope that this solves the issues you experienced. Let me know when/if you have the issues again :-) |
MartinThoma
changed the title
## What's new ### Bug Fixes (BUG) - Cope with missing /I in articles (#2134) - Fix image look-up table in EncodedStreamObject (#2128) - remove_images not operating in sub level forms (#2133) ### Robustness (ROB) - Cope with damaged PDF (#2129) ### Documentation (DOC) - How to take ownership (#2123) ### Developer Experience (DEV) - Download PDFs before executing the tests to not run into timeouts (#2143) - Add workflow_dispatch to CI (#2145) - Automatically create release message / tag message (#2127) - Ensure the REL commit message is consistently created (#2126) ### Testing (TST) - Add test for correct rendering of watermarks (#2130) [Full Changelog](3.15.4...3.15.5)
Tests which have
enable_socketand a small timeout might fail because the download isn't finished fast enough. That is not what we want to test.As a fix, CI now can download files before the actual tests are executed.