Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage of dodiscover to 95% in time for v0.1 release #90

Closed
adam2392 opened this issue Jan 11, 2023 · 0 comments · Fixed by #91
Closed

Improve coverage of dodiscover to 95% in time for v0.1 release #90

adam2392 opened this issue Jan 11, 2023 · 0 comments · Fixed by #91

Comments

@adam2392
Copy link
Collaborator

https://app.codecov.io/gh/py-why/dodiscover/tree/main/dodiscover shows the coverage by our unit-testing. A robust software package should at least aim for >90% test coverage.

This is feasible for us given that many of the API and algorithms have expected usage. The main components that we DEFINITELY should improve upon are:

  1. Context/ContextBuilder: If Context is a central ingredient for our API, then we should have full test coverage of the expected errors and edge cases
  2. CI tests
  3. Constraint-based algorithms

The first two should be relatively straightforward upon inspection of the codecov files. However, adding additional tests to the causal discovery algos may require some more thinking since these need to test different parametrizations of the algorithms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant