Post support - Bug fix! #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now on 400 status page (when occurs an error using REST server) I put the server error message (if exists) in exception.
Reading content type with json loads help dealing with data and debug
Using 4 spaces (as suggested by Guido Van Rossum) instead of tabs to indent code
Where json returns nested dictionaries, I can't check for equality using assertDictEqual, or by using collections Counts object: values can be lists with different order, so I need do sort them and check for equality with a custom method
Now extra parameters enter as url parameters in POST request as GET request. All POST methods have a 'post_parameters' attrib which is used to send data as a POST request. All failed POST tests where resolved
Now methods exclusive of ensemblgenome are defined in ensemblgenome
Sometimes ensembl REST server has problem and my tests may fail
|
Cool, thanks for your contribution. Will have a look over this asap today. |
|
All merged. Thanks for the contribution. Will update the pypi version asap. |
|
Thank you. I think I will add some little enhancements (I'm thinking to modify the rate request when the remaining requests drop down, for instance when an user submit multiple clients at the same time). When I am ready, I will do another pull request. Regards, Paolo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made some changes and updated some methods in pyEnsemblRest libraries. Brifely, I have:
nosetests --with-coverage --cover-package=ensemblrest --cover-erase(as Travis CI does)python setup.py testpython -m unittest discover -s test/There are some test that fails when Ensembl has transient problems. If I understand why, I can request an help to ensembl developer list. For now, nosetest return status 0 if such test fail. If you like such modifications, you should consider to submit this package to pypi since last uploaded version is very old.
Regards,
Paolo