Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_utils_firebase.py #83

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Update test_utils_firebase.py #83

merged 1 commit into from
Oct 26, 2022

Conversation

gcattan
Copy link
Collaborator

@gcattan gcattan commented Oct 26, 2022

Follow-up for #63.

I reintroduce in this PR the connection test that was disabled in #82 due to an unsafe context. Indeed, the base branch was in a forked repository and therefore it was unable to access this repo secret for connecting to firebase.

The main difference is that the base branch for this PR is nested inside pyRiemann-qiskit itself and not a forked repo.

@gcattan gcattan marked this pull request as ready for review October 26, 2022 09:54
@gcattan gcattan merged commit 9f54699 into main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant