-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache results for subject/pipeline #82
Conversation
- add firebase connector to init
correct bug with get_data
Add some documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me.
But tests must be corrected.
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Thank you @qbarthelemy ! The connection test is failing now because I do not have access to this repository secrets. I can either comment the failing test (firebase will not be available within gh actions) or send you the credentials by mail. |
I've just updated your role, from maintainer to admin. |
Thank you :) I am updating the secret and re-running the workflow. |
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
How is Firebase used? To store results? |
test_firebase_connection
Yes! It is used to store result, so we can for example split the work between different computers and gather the results on firebase, and use previous results instead of running another analysis. Here is a basic example from the test file:
The connection test to Firebase is making the pipeline failed. The same secret is used on my repository with no problem (gcattan#13). So I think the workflow is running into an untrusted mode because the base branch is from a fork repository (https://docs.github.com/en/actions/security-guides/encrypted-secrets#using-encrypted-secrets-in-a-workflow). This is why I will comment the connection test for the moment. |
This PR implements #63. It allows caching the result obtained for a subject in a dataset with a particular pipeline.
The PR also provides a Firebase connector to store and share results online. To enable firebase storing, the credentials must be shared privately between users or stored as a secret in the git repository.
I think it is a nice feature for offline analysis because quantum emulation is really taking a long time. We could also inherit from moabb's WithinSessionEvaluation to enable caching there too. This will make also the example on bi2012 easier to reproduce.
@toncho11, @qbarthelemy FYI