Corrected bug in FindPythonLibsNew.cmake not working with MSYS #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SYS python interpreter which uses Linux-style directories hierarchy
19 tasks
|
This was fixed about a year so, see the linked issue. Let us know if there's still a problem, especially after #2370 goes in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the following issue:
#1406
The trick consists in searching for python libraries first, which will work on linux and MSYS. Then, if it does not work and we are on a win32 host, assume a windows-like directories hierarchy and test for python library existence with such a hierarchy.