-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mingw compatibility #1851
add mingw compatibility #1851
Conversation
@kanonet I haven't tried it yet, because I don't have Windows at hand. But I see that it changes the same line as the patch from MSYS2 distro. Could you write what configurations have you tried? I see that you have OR in |
@wojdyr The Idea for this PR was taken from MSYS2 patch of cause. I did not succeed in building pybinds tests, but this allows to build pybind when it is shipped with other projects (like dlib), so those can get build. IMHO this is good enough for the moment. :) |
@kanonet Thank you for your work. Without your patch, Python libraries are not found. The patch unbreaks pybind11 on the latest msys2 (20190524). I've tested the msys64-mingw32 config, where the python executable path has to be given explicitly:
Otherwise, it picks up python from mingw64, while the session is mingw32 and complains on compiler-python arch mismatch. This seems to be msys-specific though. |
Ok, I'll go ahead and merge this then. |
This modification somewhat broke compilation with MinGW when using it without MSYS. Because, by default, MinGW does not require Furthermore, Python 3.8 does not provide
|
@Baljak , @kanonet , @dmikushin : I have no experience with MinGW/MSYS. Please create a PR if you would like further changes here. |
Update the internal version of pybind11, version 2.4.3. This release includes several fixes, such as - add fix pybind/pybind11#1851 https://github.com/pybind/pybind11/blob/v2.4.3/docs/changelog.rst Modifications from the releases: - remove test dirs - remove wheel packaging (setup.py/cfg) - remove github templates
Update the internal version of pybind11, version 2.4.3. This release includes several fixes, such as - add fix pybind/pybind11#1851 https://github.com/pybind/pybind11/blob/v2.4.3/docs/changelog.rst Modifications from the releases: - remove test dirs - remove wheel packaging (setup.py/cfg) - remove github templates
* Doc: pybind11 2.4.3+ * Internal: pybind11 2.4.3 Update the internal version of pybind11, version 2.4.3. This release includes several fixes, such as - add fix pybind/pybind11#1851 https://github.com/pybind/pybind11/blob/v2.4.3/docs/changelog.rst Modifications from the releases: - remove test dirs - remove wheel packaging (setup.py/cfg) - remove github templates Co-authored-by: Wenzel Jakob <wenzel.jakob@epfl.ch>
msys+mingw use unix-like file system not windows
fix +1406