Change non-ASCII characters to ASCII #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjakob
pushed a commit
that referenced
this pull request
Dec 4, 2015
Change non-ASCII characters to ASCII
|
Ha, interesting -- I did not realize UTF8 mdashes are forbidden. Thanks for the fix. |
|
Not forbidden, but they did cause me some issues. |
EricCousineau-TRI
referenced
this pull request
in EricCousineau-TRI/pybind11
Sep 3, 2018
…pr_1373_1367 Merge pybind#1367 and pybind#1373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As these are simply dashes, it seems reasonable to make them ASCII accepted. It also avoids some annoying python 2 encoding issues during build/install.