Add pybind11::make_key_iterator for map iteration #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't notice PR #235 before I submitted this, but I think this key iterator would be useful there, too (and, of course, there is a bit of overlap as both add the KeyError exception wrapper). |
|
I'd like to merge this fairly soon -- can you rebase it onto head whenever you have a moment? |
This allows exposing a dict-like interface to python code, allowing
iteration over keys via:
for k in custommapping:
...
while still allowing iteration over pairs, so that you can also
implement 'dict.items()' functionality which returns a pair iterator,
allowing:
for k, v in custommapping.items():
...
example-sequences-and-iterators is updated with a custom class providing
both types of iteration.
jagerman
force-pushed
the
key-iterators
branch
from
45bc3ed
to
5aa85be
Compare
|
Done. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows exposing a dict-like interface to python code, allowing iteration over keys via:
It does this via a new function, rather than overloading
py::make_iteratorfor pair containers, so that you can still expose iteration over pairs, allowing you to also provide adict.items()-compatible functionality, allowing:by defining an
__iter__method that returnspybind11::make_key_iteratorand aitemsmethod that returnspybind11::make_iterator.example6 is updated with an example class providing both types of iteration.