Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changelog for 2.10.4 #4532

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

henryiii
Copy link
Collaborator

Preparing for a 2.10.4.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

docs/changelog.rst Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henryiii
Copy link
Collaborator Author

We can try to get #4301 in here too, as long as we can answer the question of if it doesn't break on (much?) older Xcode.

@henryiii
Copy link
Collaborator Author

I think we should move ahead - #4301 is just hiding a warning in some cases, and will likely need more development.

docs/changelog.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think we should move ahead - #4301 is just hiding a warning in some cases, and will likely need more development.

+1

@henryiii henryiii merged commit c4c15d4 into pybind:master Mar 16, 2023
@henryiii henryiii deleted the henryiii/docs/changelog2104 branch March 16, 2023 20:01
henryiii added a commit that referenced this pull request Mar 16, 2023
* docs: changelog for 2.10.4

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

* Apply suggestions from code review

* Update docs/changelog.rst

---------

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

Bug Fixes:

* Fix a warning when pydebug is enabled on Python 3.11.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changelog message here is slightly misleading, since this issue could cause undefined behavior with GC-tracked objects besides just issuing a warning.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you word this?

Also, do you think #4461 was fine? I've been a bit uneasy about the change because we don't even have a unit test for it. See long discussion under #4461.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants