-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: changelog for 2.10.4 #4532
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We can try to get #4301 in here too, as long as we can answer the question of if it doesn't break on (much?) older Xcode. |
I think we should move ahead - #4301 is just hiding a warning in some cases, and will likely need more development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think we should move ahead - #4301 is just hiding a warning in some cases, and will likely need more development.
+1
* docs: changelog for 2.10.4 Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> * Apply suggestions from code review * Update docs/changelog.rst --------- Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
|
||
Bug Fixes: | ||
|
||
* Fix a warning when pydebug is enabled on Python 3.11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changelog message here is slightly misleading, since this issue could cause undefined behavior with GC-tracked objects besides just issuing a warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preparing for a 2.10.4.