feat: change array_caster in pybind11/stl.h to support value types that are not default-constructible.
#5305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
approved these changes
Aug 14, 2024
|
Thanks @henryiii! |
|
@rainwoodman FYI (this was google/pybind11clif#30034) |
henryiii
changed the title
array_caster in pybind11/stl.h to support value types that are not default-constructible.array_caster in pybind11/stl.h to support value types that are not default-constructible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loosely related: #864
However, this PR is specific to
array_caster; practically speaking, specific tostd::arrayconversions.This PR preserves the existing
array_casterbehavior as much as possible. The only difference is that it also works for value types that are not default-constructible. — Note that without this PR, the new test results in a compiler error.This PR is a backport of google/pybind11clif#30034
Suggested changelog entry:
The ``array_caster`` in pybind11/stl.h was enhanced to support value types that are not default-constructible.