Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Add asv benchmarking #207

Merged

Conversation

BradyPlanden
Copy link
Member

This PR does the following:

  • Adds Airspeed Velocity benchmarking suite
  • Adds initial benchmarking suite

Closes #179.

@BradyPlanden BradyPlanden linked an issue Feb 19, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (2b238e4) to head (2013161).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #207   +/-   ##
========================================
  Coverage    94.29%   94.29%           
========================================
  Files           33       33           
  Lines         1753     1753           
========================================
  Hits          1653     1653           
  Misses         100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden
Copy link
Member Author

This should be ready for a review now. Since it adds a new workflow, I can't manually trigger until the workflow is added to develop. I'll apply a patch to fix any bugs once this has been merged.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast, thanks @BradyPlanden! The benchmark suite looks great, I have a number of suggestions – but besides them, I would also suggest setting a fixed random seed, similar to what PyBaMM does:

import numpy as np

def set_random_seed(seed_value=42):  # or anything you like
    np.random.seed(seed_value)

in the ParameterisationBenchmark.setup() method in parameterisation_benchmark.py, or in a benchmark_util.py shim file; as you like it.

.github/workflows/periodic_benchmarks.yaml Show resolved Hide resolved
.github/workflows/periodic_benchmarks.yaml Outdated Show resolved Hide resolved
.github/workflows/periodic_benchmarks.yaml Outdated Show resolved Hide resolved
.github/workflows/periodic_benchmarks.yaml Outdated Show resolved Hide resolved
asv.conf.json Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
@BradyPlanden BradyPlanden mentioned this pull request Feb 26, 2024
5 tasks
@agriyakhetarpal
Copy link
Member

Now the benchmarks are proceeding to run, nice!

BradyPlanden and others added 4 commits March 16, 2024 10:11
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
…ement default_max_unchanged_iterations for more stable default
@BradyPlanden BradyPlanden merged commit 68b4c9b into develop Mar 18, 2024
31 checks passed
@BradyPlanden BradyPlanden deleted the 179-add-airspeed-velocity-for-automated-benchmarking branch March 18, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AirSpeed Velocity for Automated Benchmarking
2 participants