Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to likelihoods, bug fix GaussianLogLikelihood class #338

Merged
merged 93 commits into from
Jul 5, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Jun 3, 2024

Description

  • Fixes GaussianLogLikelihood for use with all optimisers,
  • Adds GaussianLogLikelihood to integration testing,
  • Updates non-bounded parameter logic,
  • Bugfix CMAES construction where x0 is destroyed.
  • Moves MAP to _likelihoods.py

Issue reference

Fixes #257

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

…t values, updt non-bounded parameter logic, bugfix pints.CMAES construction
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (76b59f1) to head (ee73c2b).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #338      +/-   ##
===========================================
+ Coverage    97.47%   97.72%   +0.24%     
===========================================
  Files           42       42              
  Lines         2419     2502      +83     
===========================================
+ Hits          2358     2445      +87     
+ Misses          61       57       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden changed the title Updates to likelihoods, bug fix GaussLogLikelihood class Updates to likelihoods, bug fix GaussianLogLikelihood class Jun 3, 2024
examples/scripts/spm_MLE.py Outdated Show resolved Hide resolved
pybop/costs/_likelihoods.py Outdated Show resolved Hide resolved
pybop/costs/_likelihoods.py Outdated Show resolved Hide resolved
pybop/costs/_likelihoods.py Outdated Show resolved Hide resolved
pybop/costs/_likelihoods.py Outdated Show resolved Hide resolved
pybop/costs/_likelihoods.py Outdated Show resolved Hide resolved
pybop/costs/_likelihoods.py Outdated Show resolved Hide resolved
pybop/costs/_likelihoods.py Outdated Show resolved Hide resolved
tests/integration/test_optimisation_options.py Outdated Show resolved Hide resolved
@NicolaCourtier NicolaCourtier mentioned this pull request Jun 7, 2024
15 tasks
@NicolaCourtier
Copy link
Member

Hi @BradyPlanden, thanks for working on this issue! I have tried adding sigma as a Parameter in #352 - please can you take a look and see what you think of this alternative implementation?

@BradyPlanden BradyPlanden requested review from NicolaCourtier and removed request for NicolaCourtier July 2, 2024 12:29
Base automatically changed from 358-passing-inputs to develop July 4, 2024 14:19
@BradyPlanden BradyPlanden changed the base branch from develop to ruff-lint-changes July 4, 2024 14:33
@BradyPlanden BradyPlanden changed the base branch from ruff-lint-changes to develop July 4, 2024 14:33
Copy link
Member

@NicolaCourtier NicolaCourtier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @BradyPlanden! I left a few small comments but the implementation looks good overall.

pybop/costs/_likelihoods.py Outdated Show resolved Hide resolved
pybop/parameters/parameter.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@BradyPlanden BradyPlanden merged commit 7a85dd0 into develop Jul 5, 2024
29 checks passed
@BradyPlanden BradyPlanden deleted the gauss-log-like-fixes branch July 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug]: GaussianLogLikelihood returns an error in the case of multiple signals
2 participants