Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model.simulateS1 to benchmarks #379

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

BradyPlanden
Copy link
Member

Description

Adds model.simulateS1 to benchmarks and adds build clean between CI runs.

Issue reference

Fixes #378

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: Benchmarks

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@BradyPlanden BradyPlanden linked an issue Jun 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (efde62d) to head (ac16694).
Report is 1 commits behind head on develop.

Current head ac16694 differs from pull request most recent head f72a85e

Please upload reports for the commit f72a85e to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #379   +/-   ##
========================================
  Coverage    97.47%   97.47%           
========================================
  Files           42       42           
  Lines         2418     2418           
========================================
  Hits          2357     2357           
  Misses          61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @BradyPlanden! I hope this will resolve the issues we previously discussed.

@BradyPlanden BradyPlanden merged commit 9ac4d01 into develop Jun 28, 2024
27 checks passed
@BradyPlanden BradyPlanden deleted the 378-add-modelsimulates1-to-benchmarks branch June 28, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add model.simulateS1 to benchmarks
2 participants