Skip to content

Commit

Permalink
Don't use pipes
Browse files Browse the repository at this point in the history 
Download the whole file first, @glyph points out that truncation attacks are a thing.
  • Loading branch information
@alex
alex committed Sep 10, 2015
1 parent 948ba5d commit 41aabcb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .travis/upload_coverage.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ set -x
NO_COVERAGE_TOXENVS=(pypy pypy3 pep8 py3pep8 docs)
if ! [[ "${NO_COVERAGE_TOXENVS[*]}" =~ "${TOXENV}" ]]; then
source ~/.venv/bin/activate
bash <(curl -s https://codecov.io/bash) -e TRAVIS_OS_NAME,TOXENV,OPENSSL
wget https://codecov.io/bash -O codecov.sh
bash codecov.sh -e TRAVIS_OS_NAME,TOXENV,OPENSSL
fi

2 comments on commit 41aabcb

@glyph
Copy link
Contributor

@glyph glyph commented on 41aabcb Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@stevepeak
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex since coveragepy v4 is available your team can use the python package instead of the bash (they both work the same). Thanks!

The reason to use bash before was to get branch conditions, but this is fixed in coverage-v4. Thanks!

Please sign in to comment.