add support for CipherContext.update_nonce #10437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reaperhulk
force-pushed
the
nonce-reset
branch
from
50c57fb
to
e5e1b83
Compare
|
This looks fantastic, thanks so much ! |
|
Hi @reaperhulk , was there anything more you planned to do before merging? |
alex
reviewed
Jul 5, 2024
alex
reviewed
Jul 5, 2024
This only supports ChaCha20 and ciphers in CTR mode.
alex
reviewed
Jul 5, 2024
alex
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only supports ChaCha20 and ciphers in CTR mode.