Memleak tests #3140
Merged
Memleak tests #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alex, thanks for your PR! By analyzing the annotation information on this pull request, we identified @reaperhulk and @Ayrx to be potential reviewers |
This was referenced Mar 7, 2017
The default malloc is CRYPTO_malloc which calls the custom ptr you provided, so it just recurses forever.
This reverts commit 37b9f3b.
|
So, very close. For some reason it fails on py35 and py26 on windows... and the tracebacks make no sense to me. @reaperhulk do you have opinions about how to dive in? really a pdb in there would go a long ways. |
|
Ok, figured out py26, it was warnings on stderr. I still have absolutely no clue about py35 |
|
Boom, tests are green now! |
reaperhulk
approved these changes
Mar 14, 2017
|
Do we intend to run more substantial tests with the memory leak checks enabled in the future? |
|
@reaperhulk I plan to add specific memleak tests for known historical leaks. I don't see a practical way to run our existing tests with leak checking. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't work, because something calls
OpenSSL_mallocin the subprocess before we initialize it. I assume this comes from theBindinginit process