-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Split OpenSSL binding from the backend interface #380
Conversation
Test FAILed. |
Test PASSed. |
Two notes:
|
Bah missed that module scope |
Test PASSed. |
Test PASSed. |
|
||
class TestOpenSSL(object): | ||
def test_binding_loads(self): | ||
assert Binding() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably assert that both lib and ffi exist and are not None.
Test PASSed. |
This looks good, except there's a merge conflict, can you merge/rebase master in? |
Test PASSed. |
@@ -67,6 +67,7 @@ The hazardous materials layer | |||
|
|||
hazmat/primitives/index | |||
hazmat/backends/index | |||
hazmat/bindings/index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this file wasn't added to the index.
And it looks like there's somehow still a merge conflict issue? |
Test PASSed. |
WIP: Split OpenSSL binding from the backend interface
Add py.test settings
No description provided.