Fix dynamodb-encryption-sdk downstream tests #4627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-sdk downstream tests boto/boto#3717
* works fine on xenial now
reaperhulk
reviewed
Dec 7, 2018
|
Thanks matt. Having it search dist-packages outside of the venv is some interesting behavior. |
|
The failing test here is unrelated (we have another PR for that). I'm going to cherry-pick this fix over into that other PR for review/merge. |
|
Merged via that PR. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix as discussed in #4626.
I also went ahead and normalized its build back to xenial, since it seems to be working just fine. I'm guessing that was modified trying to fix this issue?