Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete removal of py2 #5533

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Complete removal of py2 #5533

merged 2 commits into from
Dec 9, 2020

Conversation

alex
Copy link
Member

@alex alex commented Oct 29, 2020

fixes #5359

Note: did not remove all the __future__ imports, and there's no changelog entry.

@reaperhulk
Copy link
Member

When we're ready to land this let's split this up into multiple PRs.

@alex alex force-pushed the drop-py2 branch 5 times, most recently from 439cf67 to d8a0ec2 Compare October 29, 2020 15:12
@alex
Copy link
Member Author

alex commented Oct 29, 2020 •
edited by reaperhulk
Loading

For future alex, the parts to break this into:

  • Drop from CI, remove anything necessary for coverage
  • Change black target version to 3.6
  • Replace int_from_bytes with int.from_bytes
  • Drop all the __future__ imports
  • Drop usage of six

@alex alex force-pushed the drop-py2 branch 2 times, most recently from ed1cf52 to 5faa8fe Compare November 3, 2020 16:21
@ianw ianw mentioned this pull request Nov 4, 2020
Open
@penguinolog
Copy link

You can use isort for dropping __future__

@alex alex force-pushed the drop-py2 branch 3 times, most recently from 4eb4dfc to a7a2d68 Compare November 16, 2020 16:47
@Cartoon3636
Copy link

👍👍👍👍

@alex alex added this to the Thirty Fourth Release milestone Dec 5, 2020
This was referenced Dec 9, 2020
Merged
Merged
@alex alex force-pushed the drop-py2 branch 2 times, most recently from 5d89310 to 9aea5bc Compare December 9, 2020 05:41
This was referenced Dec 9, 2020
Merged
Merged
@alex alex changed the title Drop py2 Complete removal of py2 Dec 9, 2020
@alex alex marked this pull request as ready for review December 9, 2020 06:37
reaperhulk
reaperhulk previously approved these changes Dec 9, 2020
View reviewed changes
@reaperhulk
Copy link
Member

Needs rebase

@reaperhulk reaperhulk merged commit e66db80 into pyca:master Dec 9, 2020
@alex alex deleted the drop-py2 branch December 9, 2020 15:14
@chatne chatne mentioned this pull request Feb 8, 2021
Merged
@Jpfonseca Jpfonseca mentioned this pull request Feb 10, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@reaperhulk reaperhulk reaperhulk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
Thirty Fourth Release
Development

Successfully merging this pull request may close these issues.

Python 2.7 support timeline
4 participants
@alex @reaperhulk @penguinolog @Cartoon3636