Integrate py.test enabling python setup.py test
#678
Conversation
|
Can one of the admins verify this patch? |
| self.test_args = [] | ||
| self.test_suite = True | ||
| def run_tests(self): | ||
| #import here, cause outside the eggs aren't loaded |
There was a problem hiding this comment.
Full sentences please. e.g. # Import here because in module scope the eggs are not loaded.
There was a problem hiding this comment.
Copied verbatim from the py.test integration notes, but acknowledged.
|
@dstufft anything we should know about whether setup.py test is the worst thing in the world? |
|
ok to test |
|
Test PASSed. |
|
setup.py test is ok. You'll be installing test dependencies using setuptools but that's not super horrible. |
|
I'm mildly concerned that we're adding a new |
|
Typically what I do is: setup.py: testing_reqs = ["coverage", "pytest"]
setup(
test_requires=testing_reqs,
extras_require={
"test": testing_reqs,
},
)Then we'd need to figure out what the right magic is to get tox to isntall the test extra which I'm not sure offhand. |
|
There's a merge conflict now, can you merge/rebase master in? |
Integrate py.test according to: https://pytest.org/latest/goodpractises.html#integration-with-setuptools-test-commands Enables use of standard python setup.py test command. Very handy for OS packagers & porters for QA, in this case the FreeBSD Port for cryptography which just landed.
|
SHIP ITTTTTTTTT Edit: might wait for Travis to say so first tho |
|
Test PASSed. |
|
Docs build failure due to: Wait until this resolves itself for a pass, or ship it? Jenkins refers Test PASSed. |
- Backport python setup.py test integration PR [1] - Add OpenSSL as a dependency (Was py-openssl dependency) - Add TEST_DEPENDS and regression-test: target [1] pyca/cryptography#678
|
the vectors.txt link was just down. It sucks depending on so many online urls just for the build to pass |
Integrate py.test enabling `python setup.py test`
- Backport python setup.py test integration PR [1] - Add OpenSSL as a dependency (Was py-openssl dependency) - Add TEST_DEPENDS and regression-test: target [1] pyca/cryptography#678 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@345962 35697150-7ecd-e111-bb59-0022644237b5
- Update to 0.4 - Remove setup.py patch (Upstreamed [1]) Changes: * https://github.com/pyca/cryptography/blob/0.4/CHANGELOG.rst [1] pyca/cryptography#678
- Update to 0.4 - Remove setup.py patch (Upstreamed [1]) Changes: * https://github.com/pyca/cryptography/blob/0.4/CHANGELOG.rst [1] pyca/cryptography#678 git-svn-id: svn+ssh://svn.freebsd.org/ports/head@359958 35697150-7ecd-e111-bb59-0022644237b5
Integrate py.test according to: https://pytest.org/latest/goodpractises.html#integration-with-setuptools-test-commands
Enables use of standard python setup.py test command.
Very handy for OS packagers & porters for QA, in this case the FreeBSD Port for cryptography which just landed.