Add support for Python 3.12 #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhils
reviewed
Sep 25, 2023
.github/workflows/ci.yml
Outdated
| @@ -7,6 +7,7 @@ jobs: | |||
| linux: | |||
| runs-on: ${{ matrix.PYTHON.OS || 'ubuntu-22.04' }} | |||
| strategy: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
Suggested change
| fail-fast: false |
facutuesca
force-pushed
the
add-3.12
branch
from
5f45d54
to
8fe249b
Compare
alex
reviewed
Sep 25, 2023
.github/workflows/ci.yml
Outdated
| @@ -52,6 +55,7 @@ jobs: | |||
| uses: actions/setup-python@v4 | |||
| with: | |||
| python-version: ${{ matrix.PYTHON.VERSION }} | |||
| allow-prereleases: true | |||
There was a problem hiding this comment.
On our other repos we've preferred not to use allow-prereleases, and instead to explicitly use 3.12-dev until it's released.
mhils
previously approved these changes
Sep 25, 2023
facutuesca
force-pushed
the
add-3.12
branch
from
8fe249b
to
288010c
Compare
reaperhulk
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased branch of #1245
The Python 3.12 release candidate is out! 馃殌
See also https://dev.to/hugovk/help-test-python-312-beta-1508/