Updating certificate generation in examples #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| open('simple/CA.pkey', 'w').write(crypto.dump_privatekey(crypto.FILETYPE_PEM, cakey)) | ||
| print('Creating Certificate Authority certificate in \"simple/CA.cert\"') |
There was a problem hiding this comment.
The \ are not needed here, since you're using single quotes.
|
Besides that comment, this looks great. Thanks for doing this! |
1 similar comment
alex
added a commit
that referenced
this pull request
Apr 25, 2015
Updating certificate generation in examples
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I was looking through the examples and noticed that they had not been looked at in a while, I thought that perhaps we should update them to be more in line with what is considered contemporary good practice. In this pull request: